Add initial support for Goat A1600 RTK (#852)#949
Conversation
| from .common import GetEnableCommand, SetEnableCommand | ||
|
|
||
|
|
||
| class GetCustomCutMode(GetEnableCommand): |
There was a problem hiding this comment.
What does this option do?
Can you post a screenshot from this setting in the app
There was a problem hiding this comment.
That's what I tried to find out in my test-setup. I've tried almost everything and it's not changeable via app setting, but it probably determines which options are available in the app. It is activated for the A1600 RTK in any case.
It may enable the "Enhanced" mode..
|
I'm just trying to get to grips with the deebot and python. The MR is only intended as a very simple basic support for the A1600. |
edenhaus
left a comment
edenhaus
left a comment
There was a problem hiding this comment.
For new commands tests are required. The best would be to split adding support for the goat into a new PR, so I can merge it without waiting that all new commands are implemented. Also adding new commands need some other changes and so a split is the best imo
| class RainDelayEvent(Event): | ||
| """Rain delay event representation.""" | ||
|
|
||
| enable: bool |
There was a problem hiding this comment.
| enable: bool | |
| enabled: bool |
There was a problem hiding this comment.
Ok, so I'll remove the new commands here and this MR is just a copy of the Goat G1 for the Goat R1600.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## dev #949 +/- ##
==========================================
+ Coverage 93.07% 93.63% +0.55%
==========================================
Files 127 129 +2
Lines 4927 4997 +70
Branches 320 324 +4
==========================================
+ Hits 4586 4679 +93
+ Misses 282 258 -24
- Partials 59 60 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #949 will not alter performanceComparing Summary
|
|
This is great. One problem: Setting a moving direction is not working. |
3 participants
I still got issues with pytest, is there hardware required to run it?
ERROR tests/test_device.py - NameError: name 'x5d34r' is not definedFor now, it's just a copy of the GOAT G1
without AdvancedMode and a new CustomCutMode..